Feat(eos_designs): Add suport for l3_port_channel_interfaces for WAN #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4752
# Activate the virtual environment
source test-avd-pr-4752/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@samplePRBranch#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,samplePRBranch --force
# Optional: Install AVD examples
cd test-avd-pr-4752
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
github-actions
bot
added
role: eos_cli_config_gen
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
2f1a500 to
d3086d9
Compare
github-actions
bot
removed
role: eos_cli_config_gen
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
d3086d9 to
7d8c276
Compare
...on-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type_l3_port_channels.schema.yml
Show resolved
Hide resolved
...on-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type_l3_port_channels.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
a8fa6b9 to
1d61e17
Compare
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
2e10ead to
f35199a
Compare
github-actions
bot
added
the
state: CI Updated
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
cfae876 to
fccd4c8
Compare
XiangyiGuo
reviewed
Dec 3, 2024
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
b8175d8 to
ffc3188
Compare
ClausHolbechArista
changed the title
ClausHolbechArista
requested changes
Dec 6, 2024
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml
Outdated
Show resolved
Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml
Outdated
Show resolved
Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml
Outdated
Show resolved
Hide resolved
| peer: peerDevice2 | ||
| peer_interface: Ethernet1/12 | ||
| speed: "forced 10000full" | ||
| - # peer, peer_interface not set, use one from parent L3 Port-Channel |
There was a problem hiding this comment.
We should not use the parent peer interface in descriptions since it would be misleading (port-channel something). But I agree that we can inherit the peer.
There was a problem hiding this comment.
Fixed the comment in yml file and underlying logic to not derive peer_interface info from parent Port-Channel for a member eth port.
On a related note, what should we populate for peer_type for such member Eth ports under L3 Port-Channel when generating structured config via _get_l3_port_channel_member_ports_cfg() ?
Currently choosing not to set any value for peer_type.
Please let me know if there is a preference here.
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/static_routes.py
Outdated
Show resolved
Hide resolved
ashenoy-arista
force-pushed
the
samplePRBranch
branch
2 times, most recently
from
23138da to
c689203
Compare
ashenoy-arista
force-pushed
the
samplePRBranch
branch
from
c689203 to
41612ab
Compare
| type: str | ||
| description: |- | ||
| Interface description. | ||
| If not set a default description will be configured with '[<peer>[ <peer_port_channel>]]'. |
There was a problem hiding this comment.
Suggested change
| If not set a default description will be configured with '[<peer>[ <peer_port_channel>]]'. | |
| If not set, a default description will be configured with '[<peer>[ <peer_port_channel>]]'. |
| type: str | ||
| description: |- | ||
| Interface description for this member. | ||
| If not set a default description will be configured with '[<peer>[ <peer_interface>]]'. |
There was a problem hiding this comment.
Suggested change
| If not set a default description will be configured with '[<peer>[ <peer_interface>]]'. | |
| If not set, a default description will be configured with '[<peer>[ <peer_interface>]]'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Revised schema to support L3 Port-Channel interfaces and supporting changes to
eos_designsPrimary use-case is to allow such interfaces as wan-facing interfaces.
Related Issue(s)
Fixes #4695
Component(s) name
arista.avd.eos_designsProposed changes
How to test
This change introduces revised schema within
eos_designswith node keyl3_port_channelsto represent L3 port-channel interfaces that may be used as wan-facing interfaces.
Includes logic to support the newly added schema and unit tests to validate handling of newly added schema attributes.
Checklist
User Checklist
Repository Checklist